ZstdInputStreamNoFinalizer / ZstdOutputStreamNoFinalizer may leak buf… #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fers when these are not arrray based. Motivation: We need to put the buffers back in the pool in case of validation failure as otherwise the buffer will leak. Modifications: Handle validation and buffer lifecycle via a static helper method Result: No more leak possible
|
@luben something I noticed while reviewing some code. |
|
LGTM, can you fix or remove this test https://github.com/luben/zstd-jni/blob/master/src/test/scala/Zstd.scala#L1098-L1107 |
|
@luben fixed |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #303 +/- ##
============================================
+ Coverage 59.74% 59.87% +0.13%
Complexity 307 307
============================================
Files 26 26
Lines 1473 1473
Branches 170 170
============================================
+ Hits 880 882 +2
+ Misses 436 435 -1
+ Partials 157 156 -1 |
|
Thanks for the contribution! |
|
Just noticed this was merged without squashing which makes the history a bit messy :/ |
|
:) not big deal |
|
Thank you all! |
This was referenced Mar 28, 2024
dongjoon-hyun
added a commit
to apache/orc
that referenced
this pull request
Mar 28, 2024
### What changes were proposed in this pull request? This PR aims to upgrade `zstd-jni` to 1.5.6-1. ### Why are the changes needed? This release has the following memory-leak bug fix. - https://github.com/luben/zstd-jni/releases/tag/v1.5.6-1 - luben/zstd-jni#303 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #1865 from dongjoon-hyun/ORC-1670. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
to apache/orc
that referenced
this pull request
Mar 28, 2024
### What changes were proposed in this pull request? This PR aims to upgrade `zstd-jni` to 1.5.6-1. ### Why are the changes needed? This release has the following memory-leak bug fix. - https://github.com/luben/zstd-jni/releases/tag/v1.5.6-1 - luben/zstd-jni#303 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #1865 from dongjoon-hyun/ORC-1670. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 1830e86) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Mar 28, 2024
### What changes were proposed in this pull request? This PR aims to upgrade `zstd-jni` to 1.5.6-1. ### Why are the changes needed? This release has the following memory-leak bug fix. - https://github.com/luben/zstd-jni/releases/tag/v1.5.6-1 - luben/zstd-jni#303 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45756 from dongjoon-hyun/SPARK-47630. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? This PR aims to upgrade `zstd-jni` to 1.5.6-1. ### Why are the changes needed? This release has the following memory-leak bug fix. - https://github.com/luben/zstd-jni/releases/tag/v1.5.6-1 - luben/zstd-jni#303 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45756 from dongjoon-hyun/SPARK-47630. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Aug 7, 2024
This PR aims to upgrade `zstd-jni` to 1.5.6-1. This release has the following memory-leak bug fix. - https://github.com/luben/zstd-jni/releases/tag/v1.5.6-1 - luben/zstd-jni#303 No. Pass the CIs. No. Closes apache#45756 from dongjoon-hyun/SPARK-47630. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fers when these are not arrray based.
Motivation:
We need to put the buffers back in the pool in case of validation failure as otherwise the buffer will leak.
Modifications:
Handle validation and buffer lifecycle via a static helper method
Result:
No more leak possible