Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the new, streaming-friendly NDJSON-based qlog encoding #2736

Merged
merged 1 commit into from
Dec 6, 2020

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Sep 2, 2020

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #2736 (dd93d96) into master (5a0ce24) will decrease coverage by 0.02%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2736      +/-   ##
==========================================
- Coverage   86.24%   86.22%   -0.02%     
==========================================
  Files         133      133              
  Lines        9143     9132      -11     
==========================================
- Hits         7885     7874      -11     
+ Misses        910      909       -1     
- Partials      348      349       +1     
Impacted Files Coverage Δ
qlog/qlog.go 94.78% <58.33%> (-0.89%) ⬇️
qlog/event.go 98.81% <100.00%> (+1.15%) ⬆️
qlog/trace.go 90.00% <100.00%> (-1.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0ce24...dd93d96. Read the comment docs.

@marten-seemann marten-seemann force-pushed the qlog-ndjson branch 2 times, most recently from 35e8627 to 576f2c7 Compare December 6, 2020 03:38
@marten-seemann marten-seemann merged commit a7ddb34 into master Dec 6, 2020
@marten-seemann marten-seemann deleted the qlog-ndjson branch December 6, 2020 04:22
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants