Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only read multiple packets at a time after handshake completion #3041

Merged

Conversation

marten-seemann
Copy link
Member

It's more important that acknowledge packets in a timely manner before handshake completion. On the server side, we should send out the HANDSHAKE_DONE frame as soon as possible.

The GitHub diff looks like a big mess, but this is really just wrapping the receiveLoop in a if s.handshakeComplete.

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #3041 (53270dd) into master (74569a5) will decrease coverage by 0.01%.
The diff coverage is 72.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3041      +/-   ##
==========================================
- Coverage   86.17%   86.16%   -0.01%     
==========================================
  Files         132      132              
  Lines        9354     9355       +1     
==========================================
  Hits         8060     8060              
- Misses        937      938       +1     
  Partials      357      357              
Impacted Files Coverage Δ
session.go 77.78% <72.73%> (+0.02%) ⬆️
internal/utils/rand.go 62.50% <0.00%> (-12.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74569a5...53270dd. Read the comment docs.

@marten-seemann marten-seemann force-pushed the send-immediately-before-handshake-completion branch from 82ff2a4 to 30ec5e2 Compare February 18, 2021 02:00
@marten-seemann marten-seemann changed the title only read multiple packets at a time before handshake completion only read multiple packets at a time after handshake completion Mar 3, 2021
It's more important that acknowledge packets in a timely manner before
handshake completion. On the server side, we should send out the HANDSHAKE_DONE
frame as soon as possible.
@marten-seemann marten-seemann force-pushed the send-immediately-before-handshake-completion branch from 30ec5e2 to 53270dd Compare March 3, 2021 03:33
@marten-seemann marten-seemann merged commit 2c45f2b into master Mar 3, 2021
@marten-seemann marten-seemann deleted the send-immediately-before-handshake-completion branch March 3, 2021 03:56
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants