Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the new error types to log the reason why a connection is closed #3166

Merged
merged 2 commits into from
May 4, 2021

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented May 3, 2021

Reaping the benefits of the massive refactor: more than 200 LOC removed.

@mvdan, can I ask you for a review again?

@marten-seemann marten-seemann added this to the v0.21 milestone May 3, 2021
@marten-seemann marten-seemann changed the title se the new error types to log the reason why a connection is closed use the new error types to log the reason why a connection is closed May 3, 2021
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #3166 (42ecbf0) into master (5f2cf04) will decrease coverage by 0.03%.
The diff coverage is 96.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3166      +/-   ##
==========================================
- Coverage   85.38%   85.36%   -0.03%     
==========================================
  Files         132      131       -1     
  Lines        9831     9800      -31     
==========================================
- Hits         8394     8365      -29     
+ Misses       1063     1061       -2     
  Partials      374      374              
Impacted Files Coverage Δ
qlog/types.go 84.54% <ø> (+0.46%) ⬆️
qlog/event.go 98.11% <96.00%> (+0.11%) ⬆️
logging/multiplex.go 95.24% <100.00%> (ø)
qlog/qlog.go 91.07% <100.00%> (ø)
session.go 77.46% <100.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f2cf04...42ecbf0. Read the comment docs.

@marten-seemann marten-seemann merged commit d97f03b into master May 4, 2021
@marten-seemann marten-seemann deleted the close-reason-logging branch May 4, 2021 11:35
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants