Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposition] Dump / Export #55

Open
imclint21 opened this issue Jan 29, 2020 · 2 comments · May be fixed by #66
Open

[Proposition] Dump / Export #55

imclint21 opened this issue Jan 29, 2020 · 2 comments · May be fixed by #66

Comments

@imclint21
Copy link
Member

imclint21 commented Jan 29, 2020

Hi,

While I was eating a cake I think about making exporting/dump function.

What do you think @CephalonRho?

Best regards

@shuni64
Copy link
Contributor

shuni64 commented Jan 30, 2020

Shouldn't be too hard to do. We would have to use dashmap instead of chashmap and maybe put an RwLock around it to make sure that it doesn't change during iteration. We might also want to wait until there's progress on persistence since it could impact this significantly.

There's also the question of how we want to expose this feature. We could provide a list of all key names over http and make the client retrieve each value independently (but values could get deleted while that's happening). Once persistence is done there could just be another subcommand instead that dumps all elements to a single file in a binary format and another subcommand to load this file.

@imclint21
Copy link
Member Author

Shouldn't be too hard to do. We would have to use dashmap instead of chashmap and maybe put an RwLock around it to make sure that it doesn't change during iteration. We might also want to wait until there's progress on persistence since it could impact this significantly.

About dashmap, I already spoken with @xacrimon, but I think it was only promotion, not real benefits, but apparently it's not the case.

There's also the question of how we want to expose this feature. We could provide a list of all key names over http and make the client retrieve each value independently (but values could get deleted while that's happening). Once persistence is done there could just be another subcommand instead that dumps all elements to a single file in a binary format and another subcommand to load this file.

For me there are two things, for an endpoint go get all keys, it's surely a good idea, I don't really know how we can do that and be REST compliant, but anyway, a backup/restore command should to be implemented, for DevOps usage!

@imclint21 imclint21 linked a pull request Apr 21, 2020 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants