-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add id-card
#1296
Add id-card
#1296
Conversation
@jguddas is attempting to deploy a commit to the Lucide Team on Vercel. A member of the Team first needs to authorize it. |
Added or changed iconsIcons as codeWorks for: const IdCardIcon = createLucideIcon('IdCard', [
["path",{"d":"M16 10h2"}],
["path",{"d":"M16 14h2"}],
["path",{"d":"M6.17 15a3 3 0 0 1 5.66 0"}],
["circle",{"cx":"9","cy":"11","r":"2"}],
["rect",{"x":"2","y":"5","width":"20","height":"14","rx":"2"}]
]) |
Maybe let's call this |
@karsa-mistmere I get you, but at the same time I'm not sure if we will come up with an alternative. |
I still definitely want to make this work within the bounds of credit card, to be consistent: I feel like taking into consideration discussions in #609, these should be able to work. |
@karsa-mistmere Yeah good point. I like the second one, can we increase the length of the text lines a bit? |
|
LGTM @karsa-mistmere Go with that one? |
Now we have a 1px gap violation between the head and the body. |
Yes, but see #609 (comment) |
The violation is not really worth it, the whole icon hasn't been that hugely requested, and I'm fine with just closing this PR as well. |
I think we could make an exception for this one to accept this small violation. I'm curious what you think of this. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Pretty neat idea, I love it! Maybe it should be left to right though, I think that's a much more common layout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, still not convinced with the design, to me looks a bit weird that the user icon is out of the boundaries of the card.. 🤔
Yeah, I kinda agree. How about this one? It's maybe a bit dense, but not that bad, I guess, we definitely have worse icons by density. |
Alternatively: |
@karsa-mistmere The one you first posted seems to fit fine. On 100% scale it looks like a perfect id-card to me. |
I like this one, the first one not so much, the body has a bit of a weird gap on the lower left tho. |
Like Eric, I prefer the first one: |
Feels to dense for me. |
A bit too dense for my liking as well, but I think it's still better than any alternatives so far and it's not extremely dense by any means. |
Hello there! Is there any chance to merge this ? |
Resolves #953