Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): update pentagon icon #1918

Merged
merged 7 commits into from
Aug 2, 2024

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Feb 24, 2024

What is the purpose of this pull request?

  • Other: Icon update

Description

Hand optimised corners to have 2px radius.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Feb 24, 2024
Copy link

github-actions bot commented Feb 24, 2024

Added or changed icons

icons/pentagon.svg

Preview cohesion icons/square-library.svg
icons/pentagon.svg
icons/square-library.svg
Preview stroke widths icons/pentagon.svg
icons/pentagon.svg
icons/pentagon.svg
DPI Preview (24px) icons/pentagon.svg
Icon X-rays icons/pentagon.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const PentagonIcon = createLucideIcon('Pentagon', [
  ["path",{"d":"M10.83 2.38a2 2 0 0 1 2.34 0l8 5.74a2 2 0 0 1 .73 2.25l-3.04 9.26a2 2 0 0 1-1.9 1.37H7.04a2 2 0 0 1-1.9-1.37L2.1 10.37a2 2 0 0 1 .73-2.25z"}]
])

@karsa-mistmere
Copy link
Member

I'm not super happy about the optical volume and centre of gravity of this icon, I feel like maybe it should be scaled up towards the top as such:
image

What do you think?

@karsa-mistmere karsa-mistmere changed the title Update pentagon icon fix(icons): update pentagon icon Feb 25, 2024
@ericfennis
Copy link
Member

@karsa-mistmere To me it is not really centered if you place the icon in a single form.

ericfennis
ericfennis previously approved these changes Mar 6, 2024
@karsa-mistmere
Copy link
Member

karsa-mistmere commented Mar 6, 2024

@karsa-mistmere To me it is not really centered if you place the icon in a single form.

I find it to be a bit too bottom-heavy. 🤔

image
(top row current, bottom row proposal)

@ericfennis
Copy link
Member

@karsa-mistmere ah, seeing this. I think I'm going with your proposal

icons/pentagon.svg Outdated Show resolved Hide resolved
@ericfennis ericfennis merged commit 6272f4f into lucide-icons:main Aug 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants