Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark client commands parsing is incorrect in 1.18.2 - missing slash #486

Open
radimous opened this issue Jan 22, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@radimous
Copy link

Description

In the run method there are missing slashed before sparkc and sparkclient commands

String[] args = processArgs(context, false, "sparkc", "sparkclient");

I have fixed this with mixin and confirmed that it's working, but I can't build the 1.18.2 branch to make a PR because there are some errors with the bytesocks library (probably version issue)

@Mixin(value = ForgeClientSparkPlugin.class, remap = false)
public class MixinForgeClientSparkPlugin {
    @ModifyArg(method = "run", at = @At(value = "INVOKE", target = "Lme/lucko/spark/forge/plugin/ForgeClientSparkPlugin;processArgs(Lcom/mojang/brigadier/context/CommandContext;Z[Ljava/lang/String;)[Ljava/lang/String;"))
    private String[] fixClientCommands(String[] original) {
        return new String[]{"/sparkc", "/sparkclient"};
    }
}

anybody that is looking into temp fix until it is fixed in spark itself can get this mod that adds those slashes back radimous/spark1.18clientfix/releases/tag/v1.0

Reproduction Steps

run any command on 1.10.38 (Forge 1.18.2) starting with /sparkc and see that suggestions work, but the command itself doesn't

Expected Behaviour

/sparkc commands should work

Platform Information

  • Minecraft Version: 1.18.2
  • Platform Type: client
  • Platform Brand: forge
  • Platform Version: Forge 40.2.13

Spark Version

v1.10.38

Logs and Configs

No response

Extra Details

No response

@radimous radimous added the bug Something isn't working label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant