Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Timestamp_CreateEvent description #177

Merged
merged 1 commit into from
Apr 5, 2022
Merged

add Timestamp_CreateEvent description #177

merged 1 commit into from
Apr 5, 2022

Conversation

nkrs-lab
Copy link
Contributor

@nkrs-lab nkrs-lab commented Mar 29, 2022 •
edited by JeromeGalan
Loading

Comments for current PR

  • add your comments here
  • ...







!!! WARNING : DO NOT EDIT THE CHECKLIST BELOW !!!

Checklist : Merge to DEVELOP branch

Code Quality

  • Each function has a header (description, inputs, outputs)
  • Code is commented (particularly in hard to understand areas)
  • There are no new warnings that can be corrected
  • Commits policy is respected (constitancy commits, clear commits comments)


Tests Review

  • Manual Tests for new features have been reviewed
  • Automatic Tests for new features have been reviewed


Tests are passed the best as I can

  • Non regression existing tests are passed OK
  • New tests for new features & bug fixes are passed OK


Documentation

  • Documentation is up to date
  • Changelog for next release is up-to-date : fill here
  • If needed, tests are briefly described in test repository

nicolas-rabault
nicolas-rabault approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@nicolas-rabault nicolas-rabault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! watch out you have to rebase before merging....

@JeromeGalan JeromeGalan merged commit 693d237 into main Apr 5, 2022
@JeromeGalan JeromeGalan deleted the fix/timestamp-doc branch April 5, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-rabault nicolas-rabault nicolas-rabault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Luos contribution project
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkrs-lab @nicolas-rabault @JeromeGalan