Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if HISTORY_PAGE_LIMIT isn't set, then the UI will fetch no history records #296

Closed
ryan-lane opened this issue Jul 10, 2020 · 1 comment
Closed

if HISTORY_PAGE_LIMIT isn't set, then the UI will fetch no history records #296

ryan-lane opened this issue Jul 10, 2020 · 1 comment
Labels
backend bug client easy

Comments

@ryan-lane
Copy link
Contributor

The UI sends in limit=0 to the backend, when it should be sending limit=null (or not setting the limit argument). Another approach is to have the backend unset limit if it's 0.
@ryan-lane ryan-lane mentioned this issue Jul 10, 2020
Merged
@ryan-lane
Copy link
Contributor Author

Fixed, and released in 6.3.0.

@snyk-bot snyk-bot mentioned this issue Jan 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend bug client easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryan-lane