forked from apache/superset
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge apache 6dc760a to lyft-master #59
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve birth example dashboard * Fix tests * pylint
* Adding support for filter box in annotations * Fixing tox lint errors * fixing lint errors
* Fix: Chain var declaration and webpack invocation * enh: Add cross-env to make package.json work cross-platform * Fix: Update lock-file for new package cross-env * Chores: Update lock-file for new package cross-env
* bump a set of test-related JS libs Mostly upgrading jest as I was trying to tackle issues related to wrong source-maps reporting in jest. This addresses it * Bumping more things * lint * using core-js/stable * pointing to the right place
* Move more stuff behind ff * Fix unit tests * Fix more tests * Fix lint
…e found (apache#8037) * fix: handle case where result exists but query cannot be found * changed error code to 404 for query not found
* dashboard filter indicators * add/fix unit tests
* Add typing to db_engine_specs * Add more type annotations and docstrings * Add docstrings and typing to sql_parse and db_engine_specs * Refine select_star * Fix execute and add more docstrings * Revert kwargs change from execute * Remove redundant or * Align view and table getter schema types * Fix return type of latest_partition * Remove some typing from presto * Improve docstring for __extract_from_token
* add new chart plugins * fix: pin aphrodite version * fix: package * fix: unit test dependencies * fix: memory
Turns out since we use `git archive`, there's no need for `git clean` which was pretty disruptive.
…pache#7569) * Separate vis-specific controls from centralized controls * Remove comment * Update state's vizType when switching to a new visualization. This fixes the renderTrigger bug. * Rename functions for better readability * Fix lint issues * Fix nits * Fix vscode rename mistake
* Fix HistogramViz bug. * Fix ci black error.
* wip * Finish PR * Remove annoying snap * Fix lint * Fix js tests
* [logging] add query id to logs * add query_id to hive and presto logging
* removed database deps from reqs-dev.txt and typo. * Revert requirements-dev.txt to limit scope
* Add LogConfigurator, and add logging for CSV export * tweak for PR feedback * fix linter issue
khtruong
approved these changes
Aug 27, 2019
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS