Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cordova installed as a dev dependency #87

Closed
AssetKid opened this issue Oct 27, 2019 · 2 comments
Closed

Add support for cordova installed as a dev dependency #87

AssetKid opened this issue Oct 27, 2019 · 2 comments

Comments

@AssetKid
Copy link

AssetKid commented Oct 27, 2019

Hello,

At the moment, Cordova has to be installed globally for the generator to work

https://github.com/m0dch3n/vue-cli-plugin-cordova/blob/master/generator.js#L8-L13

It is not always possible to install packages globally due to permission restrictions. Is it possible to support Cordova installed as a dev dependencies?

Useful Links

@m0dch3n
Copy link
Owner

m0dch3n commented Nov 13, 2019

@AssetKid feel free to create PR, I'll merge it then

@AssetKid
Copy link
Author

I forgot I opened this. I did attempt to make a PR but the solution was not elegant. The cwd (i.e. src-cordova) for the cordova commands and the local dependencies install location (project root) are different.

This means npx cordova commands won't work.

I did have to hard code certain paths in the project I was working on but it was not an elegant solution. I'll close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants