Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create resources strings for all supported languages from riot API #5

Open
machado001 opened this issue Dec 24, 2024 · 2 comments
Open
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@machado001
Copy link
Owner

machado001 commented Dec 24, 2024

Today lilol supports languages changes though settings screen. User changes the languagues displayed from API.

But the strings displayed from resources isn't all supported yet.

Let's support all languages supported from riot API, also in the resources file.

To verify what are the supported languages: https://ddragon.leagueoflegends.com/cdn/languages.json

Let's create the translations but not all at once. Create issues linked with this for each translation you're intended to add.

@machado001 machado001 added this to Lilol Dec 24, 2024
@machado001 machado001 converted this from a draft issue Dec 24, 2024
@machado001 machado001 added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 24, 2024
@dignacio0815
Copy link

Hi there! Could I take this issue up?

So the main focus here is to add language res files to support all the supported LOL languages?

@machado001
Copy link
Owner Author

Hi there! Could I take this issue up?

So the main focus here is to add language res files to support all the supported LOL languages?

Hi @dignacio0815

Yes, basically this.

Please, feel free to create new pull requests for each language you want to add refeering this issue, and thanks in advance for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: To do
Development

No branches or pull requests

2 participants