Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR comment fails if message is too long #52

Open
Djiit opened this issue Mar 28, 2019 · 1 comment
Open

PR comment fails if message is too long #52

Djiit opened this issue Mar 28, 2019 · 1 comment

Comments

@Djiit
Copy link

Djiit commented Mar 28, 2019

Hi there,

Here is what I got from Jenkins when dealing with a 100+ failed snapshots result :

11:03:16  + yarn danger ci
11:03:16  yarn run v1.15.2
11:03:16  $ /home/agentadmin/workspace/front-newlook_PR-2433/node_modules/.bin/danger ci
11:03:21  Jest tests passed :+1:
11:03:21  
11:03:21  
11:03:22  Failing the build, there is 1 fail.
11:03:27  Request failed [422]: https://api.github.com/repos/onedior/front-newlook/issues/comments/477510827
11:03:27  Response: {
11:03:27    "message": "Validation Failed",
11:03:27    "errors": [
11:03:27      {
11:03:27        "resource": "IssueComment",
11:03:27        "code": "custom",
11:03:27        "field": "body",
11:03:27        "message": "body is too long (maximum is 65536 characters)"
11:03:27      }
11:03:27    ],
11:03:27    "documentation_url": "https://developer.github.com/v3/issues/comments/#edit-a-comment"
11:03:27  }
11:03:27  Feedback: undefined
11:03:28  Done in 11.56s.

Should we truncate the file if it is too long ?

@rohit-gohri
Copy link

Related issue in danger-js: danger/danger-js#919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants