Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUT /V1/products/:sku/media/:entryId does not change the file #22402

Closed
philippsander opened this issue Apr 18, 2019 · 8 comments
Closed

PUT /V1/products/:sku/media/:entryId does not change the file #22402

philippsander opened this issue Apr 18, 2019 · 8 comments
Labels
Component: Catalog Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@philippsander
Copy link
Member

philippsander commented Apr 18, 2019

Preconditions (*)

  1. Magento Commerce Edition 2.2.8
  2. Have a Product with an image uploaded (Luma sample data provides this)

Steps to reproduce (*)

  1. Send the following request to "/V1/products/24-WG080/media/52"
    base64_encoded_data is empty as this would bloat the issue-text

{"entry":{"media_type":"image","label":"Label for my Image":1,"disabled":false,"types":["image","small_image","thumbnail"],"content":{"base64_encoded_data":"...","type":"image/jpeg","name":"luma-yoga-kit-2"},"id":52}}

Expected result (*)

  1. Everything provided by the request is updated for the media entity
  2. The actual file-content is replaced with what is provided in the base64_encoded_data
  3. The endpoint returns true

Actual result (*)

  1. label, types and disabled is updated for the media entity
  2. The actual file-content is NOT replaced with what is provided in the base64_encoded_data
  3. The endpoint returns true
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 18, 2019
@ghost ghost self-assigned this Apr 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 18, 2019

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@philippsander philippsander added Component: Catalog Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" labels Apr 18, 2019
@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 18, 2019
@ghost ghost removed their assignment Apr 18, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99257, MAGETWO-99258 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 18, 2019
@Nazar65 Nazar65 self-assigned this Apr 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 18, 2019

Hi @Nazar65. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@philippsander
Copy link
Member Author

@Nazar65 Thanks for looking into this issue. keep in mind that I did not verfify this with 2.2-develop and 2.3-develop yet!

@Nazar65
Copy link
Member

Nazar65 commented Apr 18, 2019

@philippsander this issue present on 2.3-develop as well, i'm working on this now 👍

@Nazar65
Copy link
Member

Nazar65 commented Apr 19, 2019

Hi @philippsander I'm made a proper fix for this you can apply to your instance.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Apr 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @philippsander. Thank you for your report.
The issue has been fixed in #22424 by @Nazar65 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team
Copy link
Contributor

Hi @philippsander. Thank you for your report.
The issue has been fixed in #22533 by @niravkrish in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Apr 30, 2019
@philippsander philippsander reopened this Sep 18, 2019
@ghost ghost unassigned Nazar65 Sep 18, 2019
@ghost ghost removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

3 participants