Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline fields in forms have no visible label #7428

Closed
navarr opened this issue Nov 14, 2016 · 6 comments
Closed

Multiline fields in forms have no visible label #7428

navarr opened this issue Nov 14, 2016 · 6 comments
Assignees
Labels
Area: Frontend bug report Event: distributed-cd Distributed Contribution Day Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@navarr
Copy link
Member

navarr commented Nov 14, 2016

Preconditions

  1. Magento CE 2.1.2
  2. Custom <uiComponent /> form

Steps to reproduce

  1. Create a <field>
  2. Set it's formElement to multiline
  3. Load the form in the browser

(Example <field>):

    <field name="street">
        <argument name="data" xsi:type="array">
            <item name="config" xsi:type="array">
                <item name="label" xsi:type="string" translate="true">Street</item>
                <item name="dataType" xsi:type="string">text</item>
                <item name="size" xsi:type="number">2</item>
                <item name="formElement" xsi:type="string">multiline</item>
                <item name="visible" xsi:type="boolean">true</item>
                <item name="source" xsi:type="string">general</item>
                <item name="validation" xsi:type="array">
                    <item name="required-entry" xsi:type="boolean">true</item>
                </item>
            </item>
        </argument>
    </field>

Expected result

(The label "Street" to be visible to the left of the top input)

Actual result

The label ("Street" in this case) matches the following CSS rule:

.admin__field legend.admin__field-label {
    opacity: 0;
}

Rendering it invisible.

The less responsible for this was added to the code in this commit

@tkacheva
Copy link

Internal ticket MAGETWO-61202

@tkacheva tkacheva added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 21, 2016
@vkorotun vkorotun removed their assignment Nov 23, 2016
@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Area: Frontend Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 13, 2017
@magento-engcom-team magento-engcom-team self-assigned this Oct 13, 2017
@magento-engcom-team
Copy link
Contributor

@navarr, thank you for your report.
We've created internal ticket(s) MAGETWO-61202 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 13, 2017
@ishakhsuvarov ishakhsuvarov added the Event: distributed-cd Distributed Contribution Day label Mar 23, 2018
@crisdiaz
Copy link
Contributor

I´m working on it #distributed-cd

@magento-engcom-team
Copy link
Contributor

@crisdiaz thank you for joining. Please accept team invitation here and self-assign the issue.

@crisdiaz crisdiaz self-assigned this Mar 24, 2018
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 26, 2018
@magento-engcom-team
Copy link
Contributor

Hi @navarr. Thank you for your report.
The issue has been fixed in #14317 by @crisdiaz in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.5 release.

@okorshenko
Copy link
Contributor

Hi @navarr. Thank you for your report.
The issue has been fixed in #14383 by @rostyslav-hymon in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@okorshenko okorshenko added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend bug report Event: distributed-cd Distributed Contribution Day Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

8 participants