Refactor - Consolidating duplicate code. Minor bug fixes #73
+103
−137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started using magic-chunks recently and after looking through the code, I wanted to contribute a little.
I saw a decent amount of duplicated code blocks and some minor issues with grammar and parameter order that I wanted to resolve.
All tests pass with only two minor changes to the tests themselves. One of them was to eliminate the hiding of an error due to the order that the parameters were being checked. (see inline note).
Please review and provide feedback.
Thanks for making this tool, it's quite helpful!