Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrongly adds a closing tag for self-closing elements #702

Open
boris-petrov opened this issue Mar 4, 2024 · 1 comment
Open

Wrongly adds a closing tag for self-closing elements #702

boris-petrov opened this issue Mar 4, 2024 · 1 comment

Comments

@boris-petrov
Copy link
Contributor

<hr class="foobar" />

Such code is turned into:

<hr class="foobar"></hr>

Which then blows up in Ember's template compiler: <hr> elements do not need end tags. You should remove it:.

@boris-petrov
Copy link
Contributor Author

Actually this is true also for components:

<FooBar @baz="stuff" />

Becomes:

<FooBar @baz="stuff"></FooBar>

Which is wrong and changes the meaning - the component might be using has-block which will break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant