New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EVM tests #109

Closed

vyorkin opened this issue May 28, 2018 · 0 comments · Fixed by #127

Assignees

Labels

evm tag: bug fix

Milestone

Simple node (MVP)

Contributor

vyorkin commented May 28, 2018 •

edited

Loading

We need to test the whole "post" state, not just the "storage" part of it: https://github.com/poanetwork/mana/blob/master/apps/evm/test/evm_test.exs#L232

EDIT1: Forgot to mention that we need to check the callcreates and out too, according to http://ethereum-tests.readthedocs.io/en/latest/test_types/vm_tests.html#the-callcreates-section and http://ethereum-tests.readthedocs.io/en/latest/test_types/vm_tests.html#the-gas-and-output-keys

The text was updated successfully, but these errors were encountered:

vyorkin self-assigned this

vyorkin added evm tag: bug fix status: accepted status: in progress and removed status: accepted labels

vyorkin added this to the Simple node (MVP) milestone

vyorkin mentioned this issue

Fix EVM tests #127

Merged

vyorkin closed this as completed in #127

ghost removed the status: in progress label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment