-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: configure isort for code formatting #76
Comments
run this before black, due to some line width differences. |
I think we should use isort5. It includes a
Running it this way Note that isort5 has removed the |
can you summarize how our code style will change by using these different options? maybe include a snippet or two that shows the changes. given that we always run isort and then black, i'm not too concerned if there are minor incompatibilities. but, if there's a recommended way of keeping things in sync, and it matches our code style, that's definitely best. |
You can see the changes here: f4e6541 Some changes seems related to |
the changes look very reasonable. i'm on board. |
The text was updated successfully, but these errors were encountered: