Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scantrad-union] Missing manga from partner #1591

Closed
Zarh opened this issue Apr 26, 2020 · 5 comments · Fixed by #1760
Closed

[Scantrad-union] Missing manga from partner #1591

Zarh opened this issue Apr 26, 2020 · 5 comments · Fixed by #1760
Assignees
Labels
Enhancement Improvement or Feature

Comments

@Zarh
Copy link
Contributor

Zarh commented Apr 26, 2020

Did you read the troubleshooting guide
Yes

Is the website of the connector working properly / are you able to see the manga within your browser
Yes

Describe the bug
We can't see the manga from the partner page : https://scantrad-union.com/partenaires/

To Reproduce
Steps to reproduce the behavior:
For example : https://scantrad-union.com/manga/partenaire-second-life-ranker/ is missing

HakuNeko (please complete the following information):

  • Version 6.1.7
@Zarh Zarh added the Website Change Problem or Feature for existing Website label Apr 26, 2020
@XenonR XenonR self-assigned this May 4, 2020
@XenonR
Copy link
Contributor

XenonR commented May 4, 2020

@Zarh I can include the mangas from https://scantrad-union.com/partenaires/ but there is no reference to (1) https://scantrad-union.com/manga/partenaire-second-life-ranker/ Instead there's a reference to (2) https://scantrad-union.com/manga-partenaire/ranker-who-lives-a-second-time/ which seems to be the same manga, but with different chapters.
Also since (2) is just a link collection to mangadex I miss the point in adding it.

Overall some of the partenaire mangas seem to be original but a lot are just links to other sites. So i feel the connector is good as it is right now.

@Zarh
Copy link
Contributor Author

Zarh commented May 18, 2020

Sorry !! I didn't see your message previously...

So, you are right the link i gave previously wasn't good. So, the link hakuneko use to get the list of manga is this one : https://scantrad-union.com/projets/

I think it's better to use this one because it's seems complete : https://scantrad-union.com/manga/

But in this list there is a TAG "[Partenaire] " in the title of the name of mangas translated by their partner, can you also remove it when you load the titles in hakuneko, please ?

Please re-open the issue...

Again, I'm sorry for the delay.

@Zarh
Copy link
Contributor Author

Zarh commented May 21, 2020

@XenonR @ronny1982

Hi, I didn't know if read my previous message. So, i'm mentioning you just to be sure...

@XenonR XenonR reopened this May 21, 2020
@XenonR XenonR removed the Won't Fix label May 21, 2020
@XenonR
Copy link
Contributor

XenonR commented May 21, 2020

Hi, I didn't know if read my previous message. So, i'm mentioning you just to be sure...

I'll have another look when time allows it.

@XenonR
Copy link
Contributor

XenonR commented May 21, 2020

@Zarh Your last suggested list made more sense. Enjoy.

@XenonR XenonR added Enhancement Improvement or Feature and removed Website Change Problem or Feature for existing Website labels May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement or Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants