Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Any chance we could add asciibuild? #15

Closed
Bruno-366 opened this issue May 6, 2021 · 8 comments
Closed

Feature Request: Any chance we could add asciibuild? #15

Bruno-366 opened this issue May 6, 2021 · 8 comments
Labels
wontfix This will not be worked on

Comments

@Bruno-366
Copy link
Contributor

asciibuild seems like a really good option if one wants to do literate programming, I suspect that in order to add it to this action the easiest thing would be to ask asciidoctor/docker-asciidoctor to include it in their dockfile?

Here is asciibuild's dockfile from the building instructions

FROM alpine
RUN apk add --no-cache bash make build-base ruby ruby-rdoc ruby-irb ruby-bundler ruby-dev py-pip docker
RUN pip install pygments

RUN mkdir -p {{workdir}}
COPY . {{workdir}}/
WORKDIR {{workdir}}
RUN bundle install
RUN gem build asciibuild.gemspec
RUN gem install ./asciibuild-*.gem -l
RUN rm -Rf {{workdir}}
RUN apk del build-base make ruby-dev

VOLUME /usr/src
WORKDIR /usr/src

ENTRYPOINT ["asciibuild"]

One issue I could see arising is that in order to execute the pieces of code in a literate programming document is that environment needs to have installed that programming language, and so there would need to be a way to configure the docker image so that it includes the programming languages that are used by the literate programming document.

@manoelcampos
Copy link
Owner

manoelcampos commented May 6, 2021

I had never heard about literate programming, despite it's a pretty old Donald Knuth thing 😄.
I checked the examples on asciibuild and it's really amazing. It opens up a world of possibilities.
However, installing asciibuild inside the container may slow down the build process.
Maybe the best option is to request docker-asciidoctor to include it.
Please give it a try and let me know what you could get.

@Bruno-366
Copy link
Contributor Author

absolutely! :)

@manoelcampos
Copy link
Owner

Any updates on that?
If you get asciibuild installed by default on the docker container, you can just use the new post_build parameter.

@Bruno-366
Copy link
Contributor Author

haven't gotten any response from docker-asciidoctor

@manoelcampos
Copy link
Owner

In this case, maybe a pre_build parameter would fix the issue. This way, you could install anything you want in your own container. What do you think?

@manoelcampos
Copy link
Owner

The pre_build parameter was introduced in #21.
Closing this issue.

@manoelcampos manoelcampos added the wontfix This will not be worked on label Jul 14, 2021
@manoelcampos
Copy link
Owner

Please let me know if you can manage to install asciibuild using the new pre_build parameter.
I'd love to try it.

@Bruno-366
Copy link
Contributor Author

ok i'll try 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants