Replies: 1 comment 1 reply
-
There weren't any changes to MantineProvider theme type, it still uses MantineThemeOverride type – https://github.com/mantinedev/mantine/blob/master/packages/%40mantine/core/src/core/MantineProvider/MantineProvider.tsx#L18 I do not understand what the issue is. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Because of the breaking change to how theming works from Mantine 6 to 7, there is no good way to take a
MantineThemeOverride
in v6 and use it as aMantineTheme
in v7:theme
prop inMantineProvider
in v6 takes in a typeMantineThemeOverride
, and in v7 it takes in aMantineTheme
MantineTheme
DeepPartial
type used throughout theMantineThemeOverride
type causes differences in the types of properties between theMantineThemeOverride
andMantineTheme
even within the same version.It would be great if there was an official utility function to convert from a v6
MantineThemeOverride
to a v7MantineTheme
(and maybe some other things as well, for example going back and exporting the theme-merge function in a new minor version of Mantine 6).I understand that not everything in a Mantine 6 theme has a corollary in Mantine 7. So it would also be helpful to provide a detailed migration guide for each of these properties (for example, color scheme, which has been lifted out of the
MantineTheme
type entirely).In general it seems like Mantine 7 introduces an unnecessarily onerous migration path and I'm curious why there were so many breaking changes to fundamental parts of the library. It seems like lots of these changes were made without any consideration to how frustrating it might be for a consumer to accommodate it.
My company uses Mantine for several sites and migrating each of them to use Mantine 7 looks like it's going to be far more work than it really should need to be. The least this library could do is provide some utilities to make the migration easier.
Beta Was this translation helpful? Give feedback.
All reactions