Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node-sass v4.9 due to Node v10 #169

Closed
mattsoltani opened this issue Apr 26, 2018 · 3 comments
Closed

Update to node-sass v4.9 due to Node v10 #169

mattsoltani opened this issue Apr 26, 2018 · 3 comments
Assignees

Comments

@mattsoltani
Copy link

With the recent release of node v10, node-sass was broken (see sass/node-sass#2345) including node-sass-magic-importer.
This has been fixed in the v4.9 release, so node-sass-magic-importer just needs to be updated to use this version to get the fix.

@maoberlehner maoberlehner self-assigned this Apr 26, 2018
@maoberlehner
Copy link
Owner

Thanks for reporting this!

@mattsoltani
Copy link
Author

@maoberlehner Thank you for fixing this already. It doesn't seem to be released yet. When do you expect to release the update?

@maoberlehner
Copy link
Owner

maoberlehner commented May 14, 2018

Hey @mattsoltani, I've just published a new release, but I don't think this should have any effect on you. node-sass was only a devDependency of the Monorepo, so the node-sass-magic-importer package does not (explicitly) depend on any specific version of node-sass anyway (as you can see here: https://github.com/maoberlehner/node-sass-magic-importer/blob/master/packages/node-sass-magic-importer/package.json).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants