Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose evaluated properties in query results instead of serialized layer definitions #8373

Closed
mourner opened this issue Jun 20, 2019 · 0 comments · Fixed by #9198
Closed
Labels
api 📝 performance ⚡ Speed, stability, CPU usage, memory usage, or power usage

Comments

@mourner
Copy link
Member

mourner commented Jun 20, 2019

Capturing from #8195:

digging into 5 year commit history around this particular feature (query results including serialized layer), I discovered that the original intent was to return evaluated layout/paint values, not original definitions — see #879. At some point during many refactorings, this changed without anyone noticing.

We could apply a temporary fix to mitigate performance issues, but an ideal solution would be to track down where that change happened, and see if we can avoid full serialization by reverting back to outputting final values of properties evaluated at the time of the query. I'll dig into this further.

@mourner mourner added performance ⚡ Speed, stability, CPU usage, memory usage, or power usage api 📝 labels Jun 20, 2019
@mourner mourner self-assigned this Jun 20, 2019
@asheemmamoowala asheemmamoowala added this to the release-r milestone Jul 24, 2019
@asheemmamoowala asheemmamoowala removed this from the release-ristretto milestone Aug 29, 2019
@ryanhamley ryanhamley mentioned this issue Feb 10, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api 📝 performance ⚡ Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants