Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression test failures with node v10 #8537

Closed
asheemmamoowala opened this issue Jul 23, 2019 · 0 comments · Fixed by #8538
Closed

Expression test failures with node v10 #8537

asheemmamoowala opened this issue Jul 23, 2019 · 0 comments · Fixed by #8538

Comments

@asheemmamoowala
Copy link
Contributor

When upgrading from node v8 to node v10, the number-format expression tests (> yarn test-expressions number-format) are failing

number-format/currency

[
  "number-format",
  123456.789,
  {"locale": ["get", "locale"], "currency": ["get", "currency"]}
]
Difference:
Original
f([{},{"properties":{"locale":"ja-JP","currency":"JPY"}}])
**Expected: "Â¥123,457"**
**Actual: "JP¥ 123,457"**
f([{},{"properties":{"locale":"de-DE","currency":"EUR"}}])
**Expected: "€123,456.79"**
**Actual: "€ 123,456.79"**

number-format/precision

failed number-format/precision
[
  "number-format",
  987654321.2345679,
  {
    "locale": ["get", "locale"],
    "min-fraction-digits": ["get", "min"],
    "max-fraction-digits": ["get", "max"]
  }
]
Difference:
Original
f([{},{"properties":{"locale":"en-US","min":15,"max":20}}])
Expected: "987,654,321.234567900000000"
Actual: "987,654,321.234568000000000"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant