Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl-text-plugin fails to load if CSP for website doesn't allow script-src: blob: #9118

Closed
arindam1993 opened this issue Dec 17, 2019 · 0 comments · Fixed by #9122
Closed

Comments

@arindam1993
Copy link
Contributor

arindam1993 commented Dec 17, 2019

mapbox-gl-js version: 1.6.0

browser: All

Steps to Trigger Behavior

  1. Set a page's CSP to not allow script-src: blob:

Cause

Side effect of #8865 , which made a change so that the Main thread now requests the rtl-text-plugin, and generates a blob-url. It then sends the blobURL over to the worker for loading with importScripts. Prior to #8865 each worker would directly use the main url to load the rtl text plugin via importScripts directly, which would lead to multiple parallel network requests and slower load times.

However now, if the parent page doesnt allow script-src: blob: the importScripts for the blobURL will fail and causes rtl text to not be rendered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant