Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify geometry loading when populating bucket features #9405

Open
zmiao opened this issue Mar 11, 2020 · 0 comments
Open

Simplify geometry loading when populating bucket features #9405

zmiao opened this issue Mar 11, 2020 · 0 comments
Assignees
@zmiao
Labels
refactoring 🏗️

Comments

@zmiao
Copy link
Contributor

zmiao commented Mar 11, 2020

An extra step of loading geometry and generating a temporary feature was introduced in #9352, the purpose of it is that valid geometries need to come along with the feature in case within expression is used inside the filter.

Based on comment #9352 (comment), geometry loading could be handled in a cleaner way and canonical value could be passed along with the feature.
@zmiao zmiao self-assigned this Mar 11, 2020
@zmiao zmiao changed the title Simplify evaluationFeature parsing when populating bucket features Simplify geometry loading when populating bucket features Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zmiao zmiao

Labels
refactoring 🏗️
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zmiao