Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip encoding null values altogether #43

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Skip encoding null values altogether #43

merged 1 commit into from
Jun 4, 2021

Conversation

mourner
Copy link
Member

@mourner mourner commented Jun 4, 2021

Closes #42. Should keep VT fully spec-compliant while avoiding the original problem of "null" strings not making sense.

Copy link

@e-n-f e-n-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is the right thing to do, given the current vector tile spec and validation.

@mourner mourner merged commit d86c06f into master Jun 4, 2021
@mourner mourner deleted the skip-null branch June 4, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null attributes cannot be decoded by mapnik/Mapbox uploads
2 participants