From fbbcad4667e064e19744c8996fa02d50f8790c95 Mon Sep 17 00:00:00 2001
From: Yanwei Guo <yanweiguo@google.com>
Date: Wed, 5 Apr 2023 09:09:53 -0700
Subject: [PATCH] Allows empty value and sets default value for maxRetries of
 cloud run job (#7425)

* send empty value

* add client side default

* remove defaul_from_api
---
 mmv1/products/cloudrunv2/Job.yaml                              | 3 ++-
 .../terraform/tests/resource_cloud_run_v2_job_test.go          | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/mmv1/products/cloudrunv2/Job.yaml b/mmv1/products/cloudrunv2/Job.yaml
index 0cfd83e681ca..9893942d99e4 100644
--- a/mmv1/products/cloudrunv2/Job.yaml
+++ b/mmv1/products/cloudrunv2/Job.yaml
@@ -560,7 +560,8 @@ properties:
             name: "maxRetries"
             description: |-
               Number of retries allowed per Task, before marking this Task failed.
-            default_from_api: true
+            send_empty_value: true
+            default_value: 3
   - !ruby/object:Api::Type::String
     name: "observedGeneration"
     output: true
diff --git a/mmv1/third_party/terraform/tests/resource_cloud_run_v2_job_test.go b/mmv1/third_party/terraform/tests/resource_cloud_run_v2_job_test.go
index 1a365e1343a1..311c87c87a4e 100644
--- a/mmv1/third_party/terraform/tests/resource_cloud_run_v2_job_test.go
+++ b/mmv1/third_party/terraform/tests/resource_cloud_run_v2_job_test.go
@@ -157,7 +157,7 @@ resource "google_cloud_run_v2_job" "default" {
         connector = google_vpc_access_connector.connector.id
         egress = "ALL_TRAFFIC"
       }
-      max_retries = 2
+      max_retries = 0
     }
   }