Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout is divided by 1000 twice #40

Closed
Worper1997 opened this issue Jun 29, 2018 · 1 comment
Closed

Timeout is divided by 1000 twice #40

Worper1997 opened this issue Jun 29, 2018 · 1 comment

Comments

@Worper1997
Copy link

You know you're doing this twice right?
Line 46
$this->_timeout = $timeout/1000; //to seconds
Line 150,151
$options[CURLOPT_CONNECTTIMEOUT] = max(3, $this->_timeout/1000); //minimum of 1 second
$options[CURLOPT_TIMEOUT] = $this->_timeout/1000;
I really don't know why you're taking miliseconds and converting them to seconds. Seems unnecessary
I'm uploading my file including the fix for #39

rollingcurlx.class.php.zip

@whataboutpereira
Copy link

You're looking at some old version, this was fixed some while ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants