-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP8.0 - $ch to string #45
Comments
The docs say spl_object_id() is unique for life of the object so that should work. Will update the code soon. Thanks
…On Dec 4, 2020, 5:16 PM -0500, Przemysław Szustak ***@***.***>, wrote:
In PHP 8.0 curl_init() return CurlHandle instance now; previously, a resource was returned so you can't (string) $ch.
I don't know is it correct (because spl_object_id can be reused), but I changed It to:
$ch_hash = is_object($ch) ? (string)spl_object_id($ch) : (string) $ch;
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
dears, |
IN rollingcurlx.class.php Change Line 197 to: $ch_hash = spl_object_id($ch); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In PHP 8.0 curl_init() return CurlHandle instance now; previously, a resource was returned so you can't
(string) $ch
.I don't know is it correct (because spl_object_id can be reused), but I changed It to:
$ch_hash = is_object($ch) ? (string)spl_object_id($ch) : (string) $ch;
The text was updated successfully, but these errors were encountered: