Add icons style #17
Open
Add icons style #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added rules for sizing the icon, icons as black on a light background and icons as white on a dark background.
Closed
|
Hi, sorry for the late response and thanks for the PR. Currently this package only provides the minimum required css to load and render the fonts. Font size and colors are application specific so I don't want to include them in the main css file and currently there are no plans to include them in this package. In future if I decide to include them (in a separate optional file), I will let you know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added rules for sizing the icon, icons as black on a light background and icons as white on a dark background.