Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smartypants isn’t too smart about quotes #166

Closed
iclanzan opened this issue Jun 2, 2013 · 3 comments
Closed

Smartypants isn’t too smart about quotes #166

iclanzan opened this issue Jun 2, 2013 · 3 comments

Comments

@iclanzan
Copy link

iclanzan commented Jun 2, 2013

In words like don't and 'cause the straight quote should be converted to an apostrophe (right single curly quote).

Right now in a sentence like I won't do it 'cause I don't want to. the first ' gets converted to a left single quote, the second one to a right single quote and the third is unchanged which is wrong.

@iclanzan
Copy link
Author

iclanzan commented Jul 1, 2013

+1

@edemaine
Copy link

Update: Since #178, that sample sentence now translates to I won’t do it ‘cause I don’t want to. So it's correct in the middle of a word, but incorrect in 'cause.

Relatedly, I came here to report that [JavaScript](https://en.wikipedia.org/wiki/JavaScript)'s formats into <a href="https://en.wikipedia.org/wiki/JavaScript">JavaScript</a>‘s which is also the wrong apostrophe. I'm not quite sure why, given the current regex... is it being treated as at the beginning of line in this case?

@joshbruce
Copy link
Member

I see this in a lot of editors and renderers...even MS Word and Apple Pages I have to open the glyph selector to do that. Only online editor I've seen get it right is Medium.

#27

Closing as stale and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants