-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests failing in a fresh checkout #465
Tests failing in a fresh checkout #465
Comments
+1 Ditto. |
Line 2 in
is being treated like a reflink because of line 20
One can see this is expected behaviour by comparing If Apologies if this is all stating the obvious. Happy to keep looking but thought I would document this here in case someone more familiar with the code can get to a fix quicker. |
It might be that want to keep reflinking within blockquotes, of course, in which case it's simply a matter of rewriting |
Has any decision been made on this? I see two issues here:
|
It looks like you just need to delete these lines and fix the tests like this. |
But the fact that the current version marked (from master) does not pass this test in the same way. For three years, this simple test has been failing all the time... |
Agreed. There are two failing tests in the PR referenced. If you know how to fix them (as it seems you do??), please do so and contribute back. I don't know enough about Marked to do it myself; otherwise, I would. One person can't maintain this library. As evidenced by #956 |
Done #974 |
git-svn-id: https://github.com/chjj/marked.git@708 de94abd1-4c94-9ff3-2ac9-ce57b7db7bff
From the commonmark spec, I see that link definitions are allowed inside blockquotes too: So wrt commonmark, the def_blocks test looks wrong to me. |
I just cloned master and ran
node test
, and got the following failure:Not sure if this is a known issue or not, but thought I'd open a bug in case you weren't aware of it.
The text was updated successfully, but these errors were encountered: