Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[commonmark] Make blockquotes commonmark compliant #1023

Merged
merged 5 commits into from
Jan 20, 2018

Conversation

Feder1co5oave
Copy link
Contributor

@Feder1co5oave Feder1co5oave commented Jan 20, 2018

I've made blockquotes (almost 100%) compliant with the commonmark spec, and added the related test cases, from the spec itself. They all pass, but I was not able to pass example 198 and 200 because they are related to list and code fences rules. This will need to be fixed in the future if anyone's up to it.

Many thanks to @KostyaTretyak who helped in solving related issues before
This fixes #465 and fixes #974

Feder1co5oave and others added 5 commits January 19, 2018 03:58
…agraph + blockquote laziness rule, according to commonmark spec

(see review of markedjs#974. Partial replay of 98ac7a4)
… (laziness rule), or anything on the current line. Change paragraph rule accordingly, and make it non-greedy
@joshbruce joshbruce added this to the 0.4.0 - No known defects milestone Jan 20, 2018
@joshbruce
Copy link
Member

1 failing test, just for tracking:

#36. literal_quotes_in_titles failed at offset 6. Near: "<p>Foo[bar][].</p><p>Foo<ahref="/url".


Got:
<p>Foo[bar][].</p><p>Foo<ahref="/url


Expected:
<p>Foo<ahref="/url/"title="Titlewith

Believe this test is actually incorrect. Think there should be a space <a href= otherwise browser may look at this in an odd manner.

@joshbruce joshbruce merged commit 68aab24 into markedjs:master Jan 20, 2018
@Feder1co5oave Feder1co5oave deleted the new_blockquote branch January 20, 2018 22:26
@Feder1co5oave
Copy link
Contributor Author

This is caused by a compatibility break in the spec. The missing space you see is just caused by how the test system currently works - comparing after stripping all whitespace.

Read #1018 (comment)

zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
[commonmark] Make blockquotes commonmark compliant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failing in a fresh checkout
3 participants