Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional path checks #76

Open
markfinger opened this issue Apr 6, 2017 · 1 comment
Open

Optional path checks #76

markfinger opened this issue Apr 6, 2017 · 1 comment

Comments

@markfinger
Copy link
Owner

markfinger commented Apr 6, 2017

The path checks in the python side are not overly useful as the node process will detect the same issue when it tries to import the file. That being said, the python errors are more explicit and will be more familiar for python folk.

Primary benefit of this would be a saner setup for docker folk who have some eccentric mount paths. See #75

Recommend adding an optional setting that removes the os.exists checks in

if not os.path.exists(path):

@markfinger
Copy link
Owner Author

I don't have any need for this myself, so I'm happy to wait out a possible PR.

If someone would like to take this on, you'll need to tweak the aforementioned line in render.py, and you'll need to add another setting in react/conf.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant