feat: unencosed content no longer requires commas w/ multiple attrs #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlrawlings
approved these changes
Oct 6, 2021
DylanPiercey
added a commit
that referenced
this pull request
Jan 30, 2022
) (cherry picked from commit 7ca2017)
mlrawlings
pushed a commit
that referenced
this pull request
Apr 26, 2022
) (cherry picked from commit 7ca2017)
DylanPiercey
added a commit
that referenced
this pull request
Apr 26, 2022
) (cherry picked from commit 7ca2017)
DylanPiercey
added a commit
that referenced
this pull request
Apr 26, 2022
) (cherry picked from commit 7ca2017)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have special handling for parsing binary, unary and other javascript expressions even with unenclosed whitespace.
Currently though we error when there are multiple and one of then contains unenclosed whitespace.
This PR removes the restriction.