Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve marko 5 support #22

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Improve marko 5 support #22

merged 3 commits into from
Sep 28, 2022

Conversation

DylanPiercey
Copy link
Collaborator

Description

Improves Marko 5 support by:

  • automatically using the Marko 5 compiler apis when available
  • uses Marko 5's internal cache system rather than jests (which was pretty flakey for our use case).

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@DylanPiercey DylanPiercey force-pushed the improve-marko-5-support branch from 527f4a8 to 758bf9a Compare September 28, 2022 16:27
@DylanPiercey DylanPiercey merged commit 6b66e4d into main Sep 28, 2022
@DylanPiercey DylanPiercey deleted the improve-marko-5-support branch September 28, 2022 17:04
@DylanPiercey DylanPiercey mentioned this pull request Sep 28, 2022
Closed
2 tasks
@snyamathi
Copy link

This works for me (no more warnings 🎉 ) and all tests pass. Thanks for the quick turnaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DylanPiercey @snyamathi