Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tablib loader should throw if marko-tag.json renderer is not found #997

Open
mlrawlings opened this issue Feb 23, 2018 · 1 comment
Open

Comments

@mlrawlings
Copy link
Member

Bug Report

Marko Version: 4.7.5

Details

With a marko-tag.json like the following, where the renderer is explicitly set to index.marko, if the .marko extension is not registered, the file will not be found and there is no error (except any errors caused by the custom tag not being found).

{
   "renderer": "./index"
}

Expected Behavior

The taglib loader should throw if an explicitly referenced file is not found.

Actual Behavior

Silence

@tigt
Copy link
Contributor

tigt commented Aug 11, 2019

I’d like to try and fix this, but I’m curious about where in the Marko toolchain I should do the fs.exists() — my first guess is src/taglib/taglib-loader/loadTagFromProps.js’s renderer() method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants