Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh sse stream when src update #15

Merged
merged 7 commits into from
Apr 28, 2023

Conversation

bill-min
Copy link
Contributor

@bill-min bill-min commented Jan 19, 2023

Description

Currently in client-side, nothing happens when src update in <micro-frame-sse /> tag. This PR enables refresh when src update.

Motivation and Context

Screenshots (if appropriate):

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Patch coverage: 91.37% and project coverage change: +0.13 🎉

Comparison is base (fc36c57) 89.73% compared to head (2ed65d0) 89.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   89.73%   89.87%   +0.13%     
==========================================
  Files          16       17       +1     
  Lines         302      316      +14     
  Branches       68       68              
==========================================
+ Hits          271      284      +13     
- Misses          9       10       +1     
  Partials       22       22              
Impacted Files Coverage Δ
src/components/stream-source/component/helper.ts 83.33% <83.33%> (ø)
...omponents/stream-source/component/web.component.ts 86.66% <83.33%> (-3.34%) ⬇️
...onents/micro-frame-slot/component/web.component.ts 86.36% <90.90%> (+4.31%) ⬆️
...c/components/micro-frame-slot/component/node.marko 94.44% <94.11%> (+2.77%) ⬆️
...rc/components/micro-frame-slot/component/web.marko 85.71% <100.00%> (ø)
...components/stream-source/component/StreamSource.ts 100.00% <100.00%> (ø)
src/components/stream-source/component/node.marko 95.00% <100.00%> (-0.66%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DylanPiercey DylanPiercey merged commit cc259f4 into marko-js:main Apr 28, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.4.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants