Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scriptlet): remove trim from tryPrintEmbed #29

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

LuLaValva
Copy link
Member

Warning
This is only a partial fix. It prevents the template from breaking, but the scriptlet body is not formatted as a result.

Description

Since normalize is currently failing for TS scriptlet bodies, we were getting something like this for each of the groups:

b.group(["static", " ", b.trim, "const", " ", ...]

As a result, the " " was always removed out by b.trim

Next Step

Figure out why an error is being thrown in tryPrintEmbed for TS scriptlets

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (abd3561) 91.14% compared to head (8746098) 91.14%.

❗ Current head 8746098 differs from pull request most recent head a180cd7. Consider uploading reports for the commit a180cd7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files          11       11           
  Lines         418      418           
  Branches      126      126           
=======================================
  Hits          381      381           
  Misses         17       17           
  Partials       20       20           
Impacted Files Coverage Δ
src/index.ts 89.43% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DylanPiercey DylanPiercey merged commit 2124fce into main Apr 1, 2023
@DylanPiercey DylanPiercey deleted the 28-scriptlet-trim branch April 1, 2023 15:57
@github-actions
Copy link

github-actions bot commented Apr 1, 2023

🎉 This PR is included in version 1.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants