Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor to avoid client loading race condition #10

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

DylanPiercey
Copy link
Contributor

Description

Refactors to avoid an issue where the gql-client may not be registered in the client side before a gql-query is called. This should now work as long as they are both rendered in the same tick.

This PR also cleans up the lookup implementation.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 84.30% // Head: 79.55% // Decreases project coverage by -4.75% ⚠️

Coverage data is based on head (7cfb571) compared to base (1ca874b).
Patch coverage: 70.83% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   84.30%   79.55%   -4.75%     
==========================================
  Files          12       12              
  Lines         172      181       +9     
  Branches       21       17       -4     
==========================================
- Hits          145      144       -1     
- Misses         18       25       +7     
- Partials        9       12       +3     
Impacted Files Coverage Δ
src/components/gql-query/impl/browser.marko 100.00% <ø> (ø)
src/client/node.ts 61.53% <61.53%> (ø)
.../gql-query/components/gql-query-client/index.marko 56.41% <68.42%> (-6.45%) ⬇️
src/client/browser.ts 72.72% <72.72%> (ø)
src/components/gql-client/index.marko 93.33% <100.00%> (-6.67%) ⬇️
src/components/gql-mutation/index.marko 76.19% <100.00%> (-2.08%) ⬇️
src/components/gql-query/impl/server.marko 100.00% <100.00%> (+5.88%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DylanPiercey DylanPiercey merged commit bd3c146 into main Feb 14, 2023
@DylanPiercey DylanPiercey deleted the refactor-gql-client-usage branch February 14, 2023 20:34
@github-actions
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant