fix: update state when calling mutate #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Good catch, thanks for the PR! |
Codecov ReportBase: 83.81% // Head: 84.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
+ Coverage 83.81% 84.30% +0.48%
==========================================
Files 12 12
Lines 173 172 -1
Branches 21 21
==========================================
Hits 145 145
+ Misses 19 18 -1
Partials 9 9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@FiodorGherasimenco it looks good and CI is passing. Could you sign the CLA? |
|
/easycla |
|
🎉 This PR is included in version 2.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling mutate for gql-mutation is not updating state for
fetchingand response from mutate.Description
Apply
stateto a component as a setter is not affecting component state becausecomponent.stateis not an instance ofState. So to update a state from template we need to callcomponent.setState.Checklist: