From 85ccd2fb296883d347cb20730df1cdc5e686edfb Mon Sep 17 00:00:00 2001 From: Dylan Piercey Date: Mon, 6 Jan 2025 18:26:59 -0700 Subject: [PATCH] fix: issue where linked mode enabled in tests (#186) --- .changeset/blue-humans-boil.md | 5 +++++ src/index.ts | 9 ++++++--- 2 files changed, 11 insertions(+), 3 deletions(-) create mode 100644 .changeset/blue-humans-boil.md diff --git a/.changeset/blue-humans-boil.md b/.changeset/blue-humans-boil.md new file mode 100644 index 0000000..8166ff4 --- /dev/null +++ b/.changeset/blue-humans-boil.md @@ -0,0 +1,5 @@ +--- +"@marko/vite": patch +--- + +Fix issue where link mode was incorrectly left enabled in test environments. diff --git a/src/index.ts b/src/index.ts index 548320b..8a40d24 100644 --- a/src/index.ts +++ b/src/index.ts @@ -167,6 +167,12 @@ export default function markoPlugin(opts: Options = {}): vite.Plugin[] { enforce: "pre", // Must be pre to allow us to resolve assets before vite. async config(config, env) { let optimize = env.mode === "production"; + isTest = env.mode === "test"; + isBuild = env.command === "build"; + + if (isTest) { + linked = false; + } if ("MARKO_DEBUG" in process.env) { optimize = @@ -239,8 +245,6 @@ export default function markoPlugin(opts: Options = {}): vite.Plugin[] { compiler.configure(baseConfig); devEntryFile = path.join(root, "index.html"); devEntryFilePosix = normalizePath(devEntryFile); - isTest = env.mode === "test"; - isBuild = env.command === "build"; isSSRBuild = isBuild && linked && Boolean(config.build!.ssr); renderAssetsRuntimeCode = getRenderAssetsRuntime({ isBuild, @@ -249,7 +253,6 @@ export default function markoPlugin(opts: Options = {}): vite.Plugin[] { }); if (isTest) { - linked = false; const { test } = config as any; if ((test.environment as string | undefined)?.includes("dom")) {