From f5a620e1021ddb386d919eb08371f24cca8aba84 Mon Sep 17 00:00:00 2001
From: Dylan Piercey <dpiercey@ebay.com>
Date: Tue, 17 Mar 2020 10:41:10 -0700
Subject: [PATCH] fix: automatically configure webpack options when runtimeid
 set (#35)

---
 README.md           |  2 ++
 src/plugin/index.ts | 32 +++++++++++++++++++++++++++++---
 2 files changed, 31 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 652225a..753bff1 100644
--- a/README.md
+++ b/README.md
@@ -202,6 +202,8 @@ const markoPlugin = new MarkoPlugin({
 });
 ```
 
+Note: This option will also override the default values for the `jsonpFunction`, `chunkCallbackName` and `hotUpdateFunction` webpack `output` options, which all use global variables, to be prefixed with the `runtimeId`.
+
 ## Dynamic public paths
 
 When using the plugin, the server will automatically sync the runtime [`__webpack_public_path__`](https://webpack.js.org/guides/public-path/#on-the-fly) with the browser.
diff --git a/src/plugin/index.ts b/src/plugin/index.ts
index 92d5bdb..163cb41 100644
--- a/src/plugin/index.ts
+++ b/src/plugin/index.ts
@@ -1,6 +1,6 @@
 import path from "path";
 import WebpackPluginAddEntries from "./webpack-plugin-add-entries";
-import { Compiler, Entry } from "webpack";
+import { Compiler, Entry, Output } from "webpack";
 import { ReplaceSource } from "webpack-sources";
 import VirtualModulesPlugin from "webpack-virtual-modules";
 import sortKeys from "sort-keys";
@@ -59,6 +59,8 @@ export default class MarkoWebpackPlugin {
         isEvalDevtool ? JSON.stringify(code).slice(1, -1) : code;
 
       pluginOptionsForCompiler.set(compiler, this.options);
+
+      applyRuntimeIdOptions(this.options, compiler.options.output);
       registerVirtualModules(compiler, this.virtualServerModules);
 
       compiler.hooks.invalid.tap("MarkoWebpackServer:invalid", () => {
@@ -193,7 +195,9 @@ export default class MarkoWebpackPlugin {
 
       pluginOptionsForCompiler.set(compiler, this.options);
 
+      applyRuntimeIdOptions(this.options, compiler.options.output);
       registerVirtualModules(compiler, virtualModules);
+
       this.browserCompilerNames.push(compilerName);
       this.pendingBrowserBuilds.push(pendingBuild);
 
@@ -248,7 +252,7 @@ export default class MarkoWebpackPlugin {
   }
 }
 
-const createDeferredPromise = <T>() => {
+function createDeferredPromise<T>() {
   let resolve: (value: T) => void;
   const promise = new Promise(
     _resolve => (resolve = _resolve)
@@ -257,4 +261,26 @@ const createDeferredPromise = <T>() => {
   // eslint-disable-next-line @typescript-eslint/unbound-method
   promise.resolve = resolve;
   return promise;
-};
+}
+
+function applyRuntimeIdOptions(
+  pluginOptions: ConstructorParameters<typeof MarkoWebpackPlugin>[0],
+  outputOptions: Output
+) {
+  if (pluginOptions && pluginOptions.runtimeId) {
+    const { runtimeId } = pluginOptions;
+    if (outputOptions.hotUpdateFunction === "webpackHotUpdate") {
+      outputOptions.hotUpdateFunction = `${runtimeId}HotUpdate`;
+    }
+
+    if (outputOptions.jsonpFunction === "webpackJsonp") {
+      outputOptions.jsonpFunction = `${runtimeId}Jsonp`;
+    }
+
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    if ((outputOptions as any).chunkCallbackName === "webpackChunk") {
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      (outputOptions as any).chunkCallbackName = `${runtimeId}Chunk`;
+    }
+  }
+}