Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip writing dynamic publicPath if publicPath is in output options #31

Merged
merged 1 commit into from
Mar 15, 2020

Conversation

DylanPiercey
Copy link
Contributor

Description

This plugin automatically syncs the webpack_public_path from the server side compilation to the browser side using a global window variable in an injected script.

This code is no longer output if a static publicPath option is configured for both the server side and client side compiler in your webpack config.

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@DylanPiercey DylanPiercey merged commit 6d117c9 into master Mar 15, 2020
@DylanPiercey DylanPiercey deleted the skip-dynamic-public-path-if-static branch March 15, 2020 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant