Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: automatically configure webpack options when runtimeid set #35

Merged
merged 1 commit into from
Mar 17, 2020
Merged

fix: automatically configure webpack options when runtimeid set #35

merged 1 commit into from
Mar 17, 2020

Conversation

DylanPiercey
Copy link
Contributor

Description

This PR updates the runtimeId plugin option to override the default values for webpack output options which use global variables to prefix them with the runtimeId.

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@DylanPiercey DylanPiercey changed the title fix: automatically configre webpack options when runtimeid set fix: automatically configure webpack options when runtimeid set Mar 17, 2020
@DylanPiercey DylanPiercey force-pushed the runtime-id-default-webpack-options branch from dfe18b2 to 7f4a598 Compare March 17, 2020 17:23
@DylanPiercey DylanPiercey merged commit f5a620e into master Mar 17, 2020
@DylanPiercey DylanPiercey deleted the runtime-id-default-webpack-options branch March 17, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlrawlings mlrawlings mlrawlings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DylanPiercey @mlrawlings