feat: remove virtual module plugin, much refactoring, webpack 5 support #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanPiercey
force-pushed
the
remove-virtual-modules
branch
2 times, most recently
from
c4a3db9 to
4b745eb
Compare
|
This PR is not quite merge ready. Although the tests are passing and it is possible everything works, more testing is needed. If anyone would like to help with that effort I've released a pre-release ( |
DylanPiercey
force-pushed
the
remove-virtual-modules
branch
6 times, most recently
from
7e38097 to
4f1d6e3
Compare
DylanPiercey
force-pushed
the
remove-virtual-modules
branch
from
4f1d6e3 to
fbd12f3
Compare
DylanPiercey
added a commit
that referenced
this pull request
Feb 2, 2021
…rt (#48) BREAKING CHANGE: drop Marko 4 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: drops support for Marko 4 compilation
Description
This PR replaces #42.
It adds support for webpack 5, while maintaining webpack 4 support.
Marko 4 support has been dropped.
This PR is a fairly large refactor to simplify the logic and also to remove the usage of the virtual modules plugin which prevented us from supporting webpack 5.
Checklist: