Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marko stopped working after upgrade to 5.31.16 #84

Closed
xtremespb opened this issue Nov 10, 2023 · 6 comments · Fixed by #85
Closed

Marko stopped working after upgrade to 5.31.16 #84

xtremespb opened this issue Nov 10, 2023 · 6 comments · Fixed by #85

Comments

@xtremespb
Copy link

Marko Version: 5.31.16

Details

[email protected] /Users/xtreme/Documents/GitHub/heretic
├─┬ @marko/[email protected]
│ └── [email protected] deduped
└─┬ [email protected]
└─┬ @marko/[email protected]
└── [email protected] deduped

Expected Behavior

Everything was fine on 5.31.14. I expect the same behaviour on 5.31.16 ;-)

Actual Behavior

There is no re-hydration of server code, and the page is empty. The JS events are not triggered (e.g. onMount)

Possible Fix

Currently the only way for me is to downgrade to 5.31.14.

Additional Info

Your Environment

Mac OS Sonoma, MacBook Pro, 32 GB RAM
Vivaldi 6.2.3105.58

Steps to Reproduce

  1. Clone https://github.com/hereticjsorg/heretic.git
  2. npm i
  3. npm run configure
  4. npm run build -- --dev
  5. npm run server
  6. Go to http://127.0.0.1:3001
@DylanPiercey
Copy link
Contributor

@xtremespb I just cloned this down, followed your steps (but upgraded to [email protected] before installing) and the page does appear to show.

Possible there is a cache issue or something on your end? Could you clear ./node_modules/.cache (webpacks cache)?

@xtremespb
Copy link
Author

xtremespb commented Nov 10, 2023

@DylanPiercey, thank you for your investigation. This is a really strange behavior.
I realized that the problem is with marko/webpack. Steps to reproduce:

@DylanPiercey
Copy link
Contributor

Between the different installs what is the diff of the lock file?

@xtremespb
Copy link
Author

image

@DylanPiercey
Copy link
Contributor

@xtremespb thanks for the report and info.

This was in fact a regression over here. @marko/[email protected] has the fix

@xtremespb
Copy link
Author

Thank you, it works! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants